Horton
Menu

Re: Build failure with GCC 15 (defaults to -std=gnu23)

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Sam James <sam@gentoo.org>, pgsql-bugs@lists.postgresql.org
Date: 2024-11-27T14:54:15Z
Lists: pgsql-bugs 
Thomas Munro <thomas.munro@gmail.com> writes:
> On Mon, Nov 18, 2024 at 2:59 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, that's a fair criticism.  I don't think we've tested that code
>> path since I retired prairiedog, so who's to say that it works even
>> now?  Maybe it's best to just delete that code, and if we ever find a
>> new platform with wider bool, figure out what to do at that time.

> Here's a draft patch for that.

Passes an eyeball check, but I've not really tried to test it.
I suppose the only meaningful test is likely to be letting the
buildfarm loose on it.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Require sizeof(bool) == 1.

  2. If a C23 compiler is detected, try asking for C17.

  3. Fix C23 compiler warning

  4. Rename C23 keyword

  5. Assume that <stdbool.h> conforms to the C standard.

  6. Revise tree-walk APIs to improve spec compliance & silence warnings.