Horton
Menu

Re: gSoC - ADD MERGE COMMAND - code patch submission

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Fetter <david@fetter.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Boxuan Zhai <bxzhai2010@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "heikki.linnakangas@enterprisedb.com" <heikki.linnakangas@enterprisedb.com>
Date: 2010-07-10T17:53:53Z
Lists: pgsql-hackers 
David Fetter <david@fetter.org> writes:
> By the way, "make check" fails here with attached initdb.log:

> creating system views ... FATAL:  unrecognized token: "false"

Hm, I'd suspect something fouled up in keyword recognition.
Did you do a "make clean" and rebuild?

BTW, this patch is still a few bricks shy of a load, since there's no
kwlist.h change and so the new MERGE keyword couldn't possibly be
recognized.  More generally, I'm wondering why the original .rar
submission was 300k (presumably compressed) and your diff is only
about 35k ...

			regards, tom lane