Re: Replace current implementations in crypt() and gen_salt() to OpenSSL

Joe Conway <mail@joeconway.com>

From: Joe Conway <mail@joeconway.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, "Koshi Shibagaki (Fujitsu)" <shibagaki.koshi@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-04T14:52:52Z
Lists: pgsql-hackers
On 12/4/24 09:45, Daniel Gustafsson wrote:
>> On 4 Dec 2024, at 15:40, Joe Conway <mail@joeconway.com> wrote:
>> 
>> On 12/4/24 09:33, Daniel Gustafsson wrote:
>>> since OpenSSL 1.1.1 cannot operate in FIPS mode.
>> 
>> I don't think that is correct. The RHEL 8 openssl which was FIPS 140-2 validated is 1.1.1k. See:
>> 
>> https://csrc.nist.gov/CSRC/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp4642.pdf
> 
> Does RHEL publish the source of their fork somewhere?  In OpenSSL 1.1.1 the
> code for FIPS_mode is:
> 
> int FIPS_mode(void)
> {
>      /* This version of the library does not support FIPS mode. */
>      return 0;
> }
> 
> Do you know if RHEL patched OpenSSL to allow FIPS_mode() to return other than 0
> or if that function is useless regardless?

Yes the RHEL and OpenSUSE rpms for openssl are heavily patched for the 
FIPS versions, as is the Ubuntu one. It has been a while but last time I 
looked at all of this they were all using very similar patches to allow 
the "system wide" FIPS mode rather than depending on the app to 
explicitly go into FIPS_mode().

I can look for links, but investigating it involved (for example) 
installing the source rpm and then wading through hundreds of patches in 
the SOURCE directory.

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



Commits

  1. pgcrypto: Make it possible to disable built-in crypto

  2. pgcrypto: Add function to check FIPS mode

  3. citext: Allow tests to pass in OpenSSL FIPS mode

  4. pgcrypto: Remove non-OpenSSL support