Re: Document How Commit Handles Aborted Transactions

ahmedashour <a8087027@gmail.com>

From: Ahmed Ashour <a8087027@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: David Johnston <david.g.johnston@gmail.com>
Date: 2025-02-14T21:00:35Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            tested, failed

Summary:
---------
The patch adds documentation to clarify how PostgreSQL handles aborted transactions during the commit process. The changes are clear and improve the existing documentation.

Testing:
--------
1. Manually applied the patch to the latest master branch (commit 4cffc93).
2. Fixed SGML structure issues in `advanced.sgml` and `commit.sgml` by wrapping `<varlistentry>` in `<variablelist>`.
3. Rebuilt the documentation using `make html`.
4. Verified the new sections are present and correctly formatted in the generated HTML.

Feedback:
---------
- The patch was manually applied due to conflicts in `advanced.sgml` and `commit.sgml`.
- Fixed invalid SGML structure by wrapping `<varlistentry>` in `<variablelist>`.
- The documentation is accurate and follows PostgreSQL’s style guidelines.
- No additional issues were found.

Recommendation:
---------------
Ready for committer. No objections.

The new status of this patch is: Ready for Committer

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Doc: commit performs rollback of aborted transactions.