Re: tests fail on windows with default git settings
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Page <dpage@pgadmin.org>
Cc: Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>,
pgsql-hackers@postgresql.org
Date: 2024-07-10T13:25:25Z
Lists: pgsql-hackers
Dave Page <dpage@pgadmin.org> writes: > On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan <andrew@dunslane.net> wrote: >> As I was looking at this I wondered if there might be anywhere else that >> needed adjustment. One thing that occurred to me was that that maybe we >> should replace the use of "-w" in pg_regress.c with this rather less >> dangerous flag, so instead of ignoring any white space difference we would >> only ignore line end differences. The use of "-w" apparently dates back to >> 2009. > That seems like a good improvement to me. +1 regards, tom lane
Commits
-
Use diff --strip-trailing-cr in pg_regress.c
- 291c42074721 18.0 landed
-
Use diff's --strip-trailing-cr flag where appropriate on Windows
- 4506d18a9891 17.0 landed
- 628c1d1f2c82 18.0 landed