Re: Better client reporting for "immediate stop" shutdowns
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2020-12-28T18:25:14Z
Lists: pgsql-hackers
Attachments
- suppress-log-spam-for-SIGQUIT-1.patch (text/x-diff) patch
Andres Freund <andres@anarazel.de> writes: > On 2020-12-26 13:37:15 -0500, Tom Lane wrote: >>> I'd like to not log all these repeated messages into the server >>> log. It's quite annoying to have to digg through thousands of lines of >>> repeated "terminating connection..." >> Hm. That's an orthogonal issue, but certainly worth considering. >> There are a couple of levels we could consider: >> 1. Just make the logged messages less verbose (they certainly don't >> need the DETAIL and HINT lines). >> 2. Suppress the log entries altogether. > My vote would be #2, with the same reasoning as yours. The most straightforward way to do that is to introduce a new error level. Having to renumber existing levels is a bit of a pain, but I'm not aware of anything that should break in source-code terms. We make similar ABI breaks in every major release. regards, tom lane
Commits
-
Suppress log spam from multiple reports of SIGQUIT shutdown.
- 1f9158ba4812 14.0 landed
-
Improve client error messages for immediate-stop situations.
- 7e784d1dc191 14.0 landed