Horton

Re: Ryu floating point output patch

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@lists.postgresql.org, "David G. Johnston" <david.g.johnston@gmail.com>, Donald Dong <xdong@csumb.edu>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Chapman Flack <chap@anastigmatix.net>
Date: 2019-02-02T23:57:50Z
Lists: pgsql-hackers 
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> [ ryu9.patch ]

I recall having tried some earlier version on my old HPUX dinosaur,
and it worked, but this one doesn't compile:

float.c: In function `float4in':
float.c:240: error: `HUGE_VALF' undeclared (first use in this function)
float.c:240: error: (Each undeclared identifier is reported only once
float.c:240: error: for each function it appears in.)

As far as I can find, that symbol doesn't appear anywhere in the
system headers on this platform.

FWIW, I did get a successful build and core regression test run on
NetBSD 8.99/aarch64.

			regards, tom lane

Commits

  1. Provide an extra-float-digits setting for pg_dump / pg_dumpall

  2. Change floating-point output format for improved performance.

  3. Use strtof() and not strtod() for float4 input.