Horton

Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

Yasir <yasir.hussain.shah@gmail.com>

View thread View on postgr.es
From: Yasir Shah <yasir.hussain.shah@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2024-07-16T11:57:37Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           not tested
Documentation:            not tested

Hi,

I have verified following: 
  - Bug exits in PG17. I also checked it in PG16 but it does not exits there. 
  - After applying your patch, I can confirm that bug get fixed. 
  - no regression found. I ran "meson test".
  - I would like to suggest you that #includes should be included at appropriate location keeping the #includes alphabetically sorted, what I observed in the PG code as a standard:
    Your patch:
    #include <versionhelpers.h>
    #include <tlhelp32.h>

    It should be like:
    #include <tlhelp32.h>
    #include <versionhelpers.h>

Regards...


Yasir Hussain
Bitnine Global Inc.

Commits

  1. Re-enable autoruns for cmd.exe on Windows

  2. Re-enable autoruns for for cmd.exe on Windows

  3. pg_regress: Disable autoruns for cmd.exe on Windows

  4. pg_ctl: Disable autoruns for cmd.exe on Windows