Re: Upgrading postmaster's log messages about bind/listen errors
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Euler Taveira <euler@timbira.com.br>, Robert Haas <robertmhaas@gmail.com>,
Joe Conway <mail@joeconway.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-10T23:40:14Z
Lists: pgsql-hackers
Attachments
- better-multixact-wraparound-messaging.patch (text/x-diff) patch
I wrote: > I think that what would actually be of some use nowadays is a LOG-level > message emitted if the wraparound *isn't* activated immediately at start. > But otherwise, we should follow the rule that silence is golden. Concretely, how about the attached? It preserves the original "protections are now enabled" message at LOG level, but emits it only when oldestOffsetKnown becomes true *after* startup. Meanwhile, if oldestOffsetKnown is still not true at the conclusion of TrimMultiXact, then it emits a new LOG message about "protections are not active". In this way we have LOG messages but they're only emitted in "interesting" cases. I dropped the IsUnderPostmaster test because I see no good reason not to warn in standalone backends as well. I think this might actually be a reasonable candidate to back-patch, because a deficiency of the existing code is that it fails to warn you when something's wrong. But in any case I'd like to put it in HEAD. regards, tom lane
Commits
-
Make logging about multixact wraparound protection less chatty.
- 5ed6fff6b729 10.0 landed
-
Improve postmaster's logging of listen socket creation.
- f9dfa5c97766 10.0 landed
-
Reduce log verbosity of startup/shutdown for launcher subprocesses.
- 6ec4c8584c45 10.0 landed