Horton

Re: pg_rewind copies

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Heikki Linnakangas <hlinnaka@iki.fi>, Cary Huang <cary.huang@highgo.ca>, pgsql-hackers@lists.postgresql.org
Date: 2021-03-25T13:32:05Z
Lists: pgsql-hackers 
On 1/22/21 8:26 AM, Heikki Linnakangas wrote:
> On 16/12/2020 00:08, Cary Huang wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  tested, passed
>> Implements feature:       tested, passed
>> Spec compliant:           tested, passed
>> Documentation:            not tested
>>
>> Hello
>>
>> The patch seems to do as described and the regression and tap tests 
>> are passing
>> +    /*
>> +     * A local source is not expected to change while we're 
>> rewinding, so check
>> +     * that we size of the file matches our earlier expectation.
>> +     */
>> Is this a tyoo?
> 
> Yep, thanks! Attached is a new patch version, with that fixed and 
> rebased. No other changes.

Cary, does this patch look ready to commit? If so, please change the 
state in the CF entry to "Ready for Committer".

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. pg_rewind: Fetch small files according to new size.