Horton

Re: ecpglib use PQconnectdbParams

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Michael Meskes <meskes@postgresql.org>, Christian Ullrich <chris@chrullrich.net>, pgsql-hackers@postgresql.org
Date: 2012-02-08T15:19:40Z
Lists: pgsql-hackers 
Peter Eisentraut <peter_e@gmx.net> writes:
>  		if (IsUnderPostmaster)
>  			ereport(FATAL,
>  					(errcode(ERRCODE_SYNTAX_ERROR),
> -				 errmsg("invalid command-line arguments for server process"),
> +				 errmsg("invalid command-line arguments for server process: %s", argv[optind]),
>  			  errhint("Try \"%s --help\" for more information.", progname)));
>  		else
>  			ereport(FATAL,

+1 for that change, but please s/arguments/argument/ in the text.  Also,
what about the other branch of the "if" that's just out of sight here?

			regards, tom lane