Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Alexey Kondratov <a.kondratov@postgrespro.ru>, Liudmila Mantrova <l.mantrova@postgrespro.ru>, Thomas Munro <thomas.munro@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, David Steele <david@pgmasters.net>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2020-01-19T21:48:05Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Jan-19, Michael Paquier wrote:
>> +use File::Glob ':bsd_glob';
>> +use File::Path qw(remove_tree make_path);
>> +use File::Spec::Functions qw(catdir catfile);
>> Is this compatible with our minimum perl requirements for the TAP
>> tests?

> I *think* :bsd_glob should be available in all the Perl versions we
> support, but I'm not sure that we really need it.  We seem to do just
> fine with regular glob elsewhere.

We had some previous discussion about that, and Andrew seemed to
think that it wouldn't necessarily be a net win:

https://www.postgresql.org/message-id/fde787ee-9c2d-46da-3ece-f7ae64a70b33%402ndQuadrant.com

In any case, I'd say -1 to having just one place use that.

			regards, tom lane