Re: behaviour change - default_tablesapce + partition table

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Rushabh Lathia <rushabh.lathia@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2019-05-20T04:30:30Z
Lists: pgsql-hackers
On 2019/05/17 12:40, Rushabh Lathia wrote:
> Hi,
> 
> Consider the below test:
> 
> create tablespace mytbs location '/home/rushabh/mywork/workspace/pg/';
> create table test ( a int , b int ) partition by list (a);
> 
> set default_tablespace to mytbs;
> create table test_p1 partition of test for values in (1);
> 
> In the above test, after the setting the default_tablespace I am creating
> a partition table and expecting that to get created under "mytbs"
> tablespace.
> 
> But that is not the case:
> 
> postgres@66247=#select relname, reltablespace from pg_class where relname =
> 'test_p1';
>  relname | reltablespace
> ---------+---------------
>  test_p1 |             0
> (1 row)
> 
> I noticed the behaviour change for default_tablespace with partition table
> with below commit.
> 
> commit 87259588d0ab0b8e742e30596afa7ae25caadb18
> Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
> Date:   Thu Apr 25 10:20:23 2019 -0400
> 
>     Fix tablespace inheritance for partitioned rels
> 
>     Commit ca4103025dfe left a few loose ends.  The most important one
>     (broken pg_dump output) is already fixed by virtue of commit
>     3b23552ad8bb, but some things remained:
> 
> I don't think that new behaviour is intended

Should we add this to open items?

Thanks,
Amit




Commits

  1. Fix default_tablespace usage for partitioned tables

  2. Fix tablespace inheritance for partitioned rels

  3. Make pg_dump emit ATTACH PARTITION instead of PARTITION OF

  4. Fix tablespace handling for partitioned tables