Horton

Re: Add Nullif case for eval_const_expressions_mutator

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Steele <david@pgmasters.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-02T09:08:34Z
Lists: pgsql-hackers 
On 30.03.21 11:20, Peter Eisentraut wrote:
> On 24.03.21 11:52, houzj.fnst@fujitsu.com wrote:
>>> +                if (!has_nonconst_input)
>>> +                    return ece_evaluate_expr(expr);
>>>
>>> That's not okay without a further check to see if the comparison 
>>> function used
>>> by the node is immutable.  Compare ScalarArrayOpExpr, for instance.
>>
>> Thanks for pointing it out.
>> Attaching new patch with this change.
> 
> This patch looks okay to me and addresses all the feedback that was 
> given.  If there are no more comments, I'll commit it in a few days.

done

Commits

  1. Add support for NullIfExpr in eval_const_expressions