Re: recent deadlock regression test failures
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Kevin Grittner <kgrittn@gmail.com>, Andres Freund <andres@anarazel.de>,
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-04-08T04:22:04Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes: > Here is an attempt at option 2 from the menu I posted above. Questions: > 1. Does anyone object to this extension of pg_blocking_pids()'s > remit? If so, I could make it a separate function (that was option > 3). It seems an entirely principle-free change in the function's definition. I'm not actually clear on why Kevin wanted this change in isolationtester's wait behavior anyway, so maybe some clarification on that would be a good idea. But if we need it, I think probably a dedicated function would be a good thing. We want the wait-checking query to be as trivial as possible at the SQL level, so whatever semantic oddities it needs to have should be pushed into C code. regards, tom lane
Commits
-
Move isolationtester's is-blocked query into C code for speed.
- 511540dadf11 10.0 landed