Re: Keepalives win32
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-28T18:45:05Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > [ can't read system's keepalive values in windows ] > The way I see it, we have two options: > 1) Read the default value from the registry. That's some fairly ugly code, imho. > 2) Ignore the registry value and use the default value of 2 hours/1 > second. That will override any changes the user made in the registry, > which seems pretty ugly. > 3) Require that these two parameters are always specified together (on > windows). Which is annoying. I vote for #2. It's the least inconsistent --- we don't pay attention to the registry for much of anything else, do we? In practice I think people who were setting either would set both, so it's not worth a huge amount of effort to have an unsurprising behavior when only one is set. regards, tom lane