Re: Need a builtin way to run all tests faster manner
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Stephen Frost <sfrost@snowman.net>,
pgsql-hackers@postgresql.org
Date: 2017-03-11T17:05:23Z
Lists: pgsql-hackers
Attachments
- fix-parallel-test-in-test_decoding.patch (text/x-diff) patch
I wrote: > I believe the core problem is that contrib/test_decoding's regresscheck > and isolationcheck targets each want to use ./tmp_check as their > --temp-instance. make has no reason to believe it shouldn't run those > two sub-jobs in parallel, but when it does, we get two postmasters trying > to share the same directory. This looks reasonably straightforward to > solve, but I'm not entirely familiar with the code here, and am not > sure what is the least ugly way to fix it. Enlarging on that: if I cd into contrib/test_decoding and do "make check -j4" or so, it reliably fails. With the attached patch, it passes. This is a localized patch that only fixes things for contrib/test_decoding; what I'm wondering is if it would be better to establish a more widespread convention that $(pg_isolation_regress_check) should use a different --temp-instance directory than $(pg_regress_check) does. regards, tom lane
Commits
-
Improve isolation tests infrastructure.
- 60f826c5e624 10.0 landed