Re: Segfault on logical replication to partitioned table with foreign children
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
Dilip Kumar <dilipbalaut@gmail.com>,
"pgsql-hackers@lists.postgresql.org"
<pgsql-hackers@lists.postgresql.org>
Date: 2022-11-02T16:37:42Z
Lists: pgsql-hackers
Since we're getting pretty close to the next set of back-branch releases, I went ahead and pushed a minimal fix along the lines suggested by Shi Yu. (I realized that there's a second ExecFindPartition call in worker.c that also needs a check.) We still can at leisure think about refactoring CheckSubscriptionRelkind to avoid unnecessary lookups. I think that is something we should do only in HEAD; it'll just be a marginal savings, not worth the risks of API changes in stable branches. The other loose end is whether to worry about a regression test case. I'm inclined not to bother. The only thing that isn't getting exercised is the actual ereport, which probably isn't in great need of routine testing. regards, tom lane
Commits
-
Defend against unsupported partition relkind in logical replication worker.
- be541efbfd11 16.0 landed
- a5b7821fc908 14.6 landed
- 4d3f7e75c8a3 13.9 landed
- 414d29a826f3 15.1 landed