Re: Buglets in equivclass.c
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-05T17:17:27Z
Lists: pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes: > On Mon, 5 Oct 2020 at 06:29, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I'm unsure whether to back-patch either of these. They both seem to be >> just latent bugs so far as the core code is concerned, but the first one >> in particular seems like something that could bite extension code. >> Thoughts? > That's a good question. I'm leaning towards backpatching both of them. > The 2nd is new as of v13, so it does not seem unreasonable that > someone has just not yet stumbled on it with some extension that adds > extra child ECs. I can imagine a use case for that, by getting rid of > needless equality quals that duplicate the partition constraint. The > fix for the first just seems neater/faster/correct, so I can't really > see any reason not to backpatch it. Yeah, that's my conclusion too after sleeping on it. Pushed, thanks for reviewing. regards, tom lane
Commits
-
Fix two latent(?) bugs in equivclass.c.
- e3bd026fbb91 9.5.24 landed
- f6a23344f8c8 9.6.20 landed
- d5109a163f46 11.10 landed
- d1c23d726d50 13.1 landed
- 74dae41e5ac3 10.15 landed
- 53c6daff4364 14.0 landed
- 1f94d76856bc 12.5 landed