Re: Rare SSL failures on eelpout

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-05T14:33:08Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> BTW, I went looking for other failures on the buildfarm I noticed that
> even for eelpout it's only happening on master and REL_11_STABLE:

Yeah, I'd noticed that.

> Disappointingly, that turned out to be just because 10 and earlier
> didn't care what the error message said.

That is, you can reproduce the failure on old branches?  That lets
out a half-theory I'd had, which was that Andres' changes to make
the backend always run its socket in nonblock mode had had something
to do with it.  (Those changes do represent a plausible reason why
SSL_shutdown might be returning WANT_READ/WANT_WRITE; but I'm not
in a hurry to add such code without evidence that it actually
happens and something useful would change if we retry.)

			regards, tom lane


Commits

  1. Hack back-branch SSL tests to avoid intermittent buildfarm failures.

  2. Restructure libpq's handling of send failures.