Horton

Re: BUG #15460: Error while creating index or constraint

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: paul.vanderlinden@mapcreator.eu, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2018-10-29T18:39:51Z
Lists: pgsql-bugs 
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Oct 29, 2018 at 4:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That's a poor excuse for ignoring the message style guidelines.
>> There are many reasons why even experts could get confused trying
>> to follow badly-written messages.

> I'll change the trace_sort messages to refer to "worker n" -- that
> should bring the trace_sort output in line with our style guidelines.

WFM.

			regards, tom lane

Commits

  1. Have BufFileSize() ereport() on FileSize() failure.

  2. Use 64 bit type for BufFileSize().

  3. Adjust trace_sort log messages.

  4. Fix some sloppiness in the new BufFileSize() and BufFileAppend() functions.