Horton

Re: [PATCH] Do not use StdRdOptions in Access Methods

Nikolay Shaplov <dhyan@nataraj.su>

View thread View on postgr.es
From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dent John <denty@qqdd.eu>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Date: 2019-11-13T13:26:53Z
Lists: pgsql-hackers

Attachments

В письме от среда, 13 ноября 2019 г. 16:05:20 MSK пользователь Michael Paquier 
написал:

Guys! Sorry for being away for so long. I did not have much opportunities to 
pay my attention to postgres recently.

Thank you for introducing build_reloptions function. It is approximately the 
direction I wanted to move afterwards myself. 

But nevertheless, I am steady on my way, and I want to get rid of StdRdOptions 
before doing anything else myself. This structure is long outdated and is not 
suitable for access method's options at all.

I've changed the patch to use build_reloptions function and again propose it 
to the commitfest.



-- 
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)

Commits

  1. Refactor reloption handling for index AMs in-core

  2. Cleanup code in reloptions.h regarding reloption handling

  3. Refactor code building relation options

  4. Add some assertions to view reloption macros