Re: Yet another (minor) fix in BRIN
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-08T03:45:26Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2020-Nov-08, Tomas Vondra wrote: >> While rebasing some of the BRIN patches, I noticed some of the code in >> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab >> which moved some of the code from brin_new_memtuple, not removing the >> shared pieces. In practice this is benign, of course. >> >> Barring objections I'll get the attached fix committed and backpatched. > LGTM, thanks for noticing. The weekend before stable-branch releases is probably not the best time to be pushing "minor" fixes into those branches. I got my fingers burned today, and so did Peter. Don't follow our example ;-) regards, tom lane
Commits
-
Remove duplicate code in brin_memtuple_initialize
- 1186a9d65d99 10.16 landed
- c4424d33cca9 11.11 landed
- 0d0626e27d56 12.6 landed
- c885e4a2f93c 13.2 landed
- 42c63ab6e2c3 14.0 landed