Re: Failure in commit_ts tap tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-23T14:03:14Z
Lists: pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes: > On 01/20/2017 01:22 PM, Tom Lane wrote: >> It looks like at least part of the answer is that the buildfarm isn't >> running this test. AFAICS, it runs "make installcheck" not >> "make check" in src/test/modules. I don't know whether any of the >> critters would have duplicated the failure, but they weren't trying. > Is there a reason why these tests aren't run under installcheck? If > there is a justification I can look at it, or we should decide on one > canonical mode of running the tests and stick to that. Well, for at least some of them, "make check" is necessary because they need to change postmaster parameters or load special shared libraries. regards, tom lane
Commits
-
Remove test for COMMENT ON DATABASE
- 7fb29ea9c626 9.5.6 landed
- 56b42a334167 9.6.2 landed
- 331f8c311b7b 10.0 landed
-
tests: Use the right Perl operator
- a600ee9e3fcc 10.0 landed