Horton

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Guillaume Lelarge <guillaume@lelarge.info>, Greg Sabino Mullane <htamfids@gmail.com>, Michael Christofides <michael@pgmustard.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-11-27T03:19:46Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> On Tue, 26 Nov 2024 at 12:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm kind of -0.5, but I'd not bothered to vote because it was
>> pretty clear what the result was going to be.

> Just so I can properly understand, how much of the -0.5 is "don't like
> the idea" vs "rather make changes to well-known behaviour"?

Well, I'm with Robert in that I've not found the buffer counts to be
all that useful most of the time.  I grant that they're sometimes
useful, but that's not enough to justify them being on by default:
EXPLAIN output is cluttered enough already.  And I'm also not
thrilled with changing longstanding behavior, but that's a
relatively minor point in this case.

			regards, tom lane

Commits

  1. Fix further fallout from EXPLAIN ANALYZE BUFFERS change

  2. Add missing BUFFERS OFF in regression tests, take 2

  3. Add missing BUFFERS OFF in select_into regression tests

  4. Enable BUFFERS with EXPLAIN ANALYZE by default