Re: auto_explain produces invalid JSON
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-11T20:22:11Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > But ExplainBeginOutput says: > case EXPLAIN_FORMAT_JSON: > /* top-level structure is an array of plans */ > appendStringInfoChar(es->str, '['); > Now that's not true in the auto-explain case, which prints one query + > one plan. What about queries that expand to multiple plans because of rules? > Since this is an exposed API, I don't think we can just change it. We > probably need a new API that does the right thing for beginning and > ending auto_explain output. (ExplainBeginLabeledOutput?) I'm inclined to think that this is auto_explain's error, not that of the core code, ie we should be changing the output. regards, tom lane