Re: gen_guc_tables.pl: Validate required GUC fields before code generation

Mahmoud Ayman <mahmoud.ayman.fcai@gmail.com>

From: Mahmoud Ayman <mahmoud.ayman.fcai@gmail.com>

To: pgsql-hackers@lists.postgresql.org

Cc: Chao Li <li.evan.chao@gmail.com>

Date: 2025-11-18T19:33:47Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

gen_guc_tables.pl: Validate required GUC fields before code generation
- 7169c0b96bb8 19 (unreleased) landed

The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

I tested patch v2 on top of current master.

- The patch applies cleanly.
- Full build and regression tests pass (“All 231 tests passed.”).
- I tested the validation by removing the `max` field from an int GUC
  (archive_timeout). The script now reports a clear error pointing to the
  exact line and missing field, instead of Perl “uninitialized value” warnings.
- Verified that the generated guc_tables.c output is unchanged.
- The added validation code is small and straightforward, and integrates
  cleanly into the existing script.

Everything works as described.  
I think this patch is ready for committer.

Reviewed-by: Mahmoud Ayman

The new status of this patch is: Ready for Committer