Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Jan Urbański <wulczer@wulczer.org>, pgsql-hackers@postgresql.org, Shigeru HANADA <hanada@metrosystems.co.jp>

Date: 2010-12-26T17:17:41Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add foreign data wrapper error code values for SQL/MED.
- 85cff3ce7f36 9.1.0 cited

Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Dec 26, 2010 at 8:03 AM, Jan Urbaski <wulczer@wulczer.org> wrote:
>> See
>> https://github.com/wulczer/postgres/commit/44fc42b7708f23483156e4e0e1e321e68b2a7e2d#diff-0
>> for something that maybe could be used as a basis to autogenerate
>> errcodes.sgml and plerrcodes.h.

> Interesting.  It looks like this might be even easier with perl.

The reason those files aren't autogenerated already is that at the time,
we had a policy of not requiring perl during a build.  Now that that
restriction has gone down the drain, it might be worth thinking about.

> Proposed patch attached.  This adds what I believe to be the correct
> incantations to errcodes.sgml and plerrcodes.h, and also corrects a
> typographical error in yesterday's commit which I failed to notice
> while reviewing.

Hmm.  Even with the typo fixed, ERRCODE_FDW_UNABLE_TO_CREATE_EXECUTION
seems pretty darn opaque.  Is it missing a word?  Can we rephrase it so
people will have some idea what it means?

			regards, tom lane