Re: Bug with pg_ctl -w/wait and config-only directories
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Fujii Masao <masao.fujii@gmail.com>, "Mr. Aaron W. Swenson" <titanofold@gentoo.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2011-10-03T16:54:56Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix nested PlaceHolderVar expressions that appear only in targetlists.
- ceaf5052c6a7 8.4.9 cited
Bruce Momjian <bruce@momjian.us> writes: > Config-only directories seem to be only adding confusion. All possible > solutions seem to be adding more code and user requirements, which the > creation of symlinks avoids. > Is it time for me to ask on 'general' if removal of this feature is > warranted? Well, the way we could fix it is to invent the parse-the-config-files option that was alluded to recently. Then pg_ctl would continue to take the -D switch or PGDATA environment variable with the same meaning that the postmaster attaches to it, and would do something like postgres --print-config-value=data_directory -D $PGDATA to extract the actual location of the data directory. Whether this is worth the trouble is highly debatable IMO. One obvious risk factor for pg_ctl stop/restart is that the current contents of postgresql.conf might not match what they were when the postmaster was started. I was never exactly thrilled with the separate-config-directory design to start with, so I'm probably not the person to opine on whether we could get away with removing it. regards, tom lane