Horton

Re: narwhal and PGDLLIMPORT

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Hiroshi Inoue <inoue@tpf.co.jp>, Craig Ringer <craig@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2014-02-09T18:19:55Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Sun, Feb 9, 2014 at 4:04 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> In the meantime, here's a short patch trying the "#define extern" approach.
>> Anyone want to try this on a Windows machine or two?

> There are quite a few warnings and errors in build:

Hmm.  Looks like the #define is messing up the handling of "extern"s
appearing in system headers.  There's likely no good way around that,
at least none with the simplicity that's the only redeeming value
of this approach.  So this won't work, and we should be looking at
whether it will help to not use dlltool anymore (per other emails
in this thread).

Thanks for doing the testing!

			regards, tom lane