Thread

Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ?

Mircea Cadariu <cadariu.mircea@gmail.com> — 2025-09-16T13:05:45Z

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi, 

I tested the patch with log_statement = 'all' and I confirm I do not see the VACUUM log line anymore. 

You could consider adding the following representative test in src/bin/scripts/t/100_vacuumdb.pl: 
$node->issues_sql_unlike(
    [ 'vacuumdb', '--analyze-only', 'postgres' ],
    qr/statement: VACUUM.*;/,
    'vacuumdb --analyze-only skips vacuum');

Kind regards,
Mircea Cadariu

The new status of this patch is: Waiting on Author