Re: Poll: are people okay with function/operator table redesign?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
Steven Pousty <steve.pousty@gmail.com>,
Pavel Stehule <pavel.stehule@gmail.com>,
Isaac Morland <isaac.morland@gmail.com>,
Pierre Giraud <pierre.giraud@dalibo.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-04-17T00:25:09Z
Lists: pgsql-hackers
Attachments
- table-9.10-v3.png (image/png)
- table-9.30-v3.png (image/png)
- doc-format-v3.patch (text/x-diff) patch v3
- website-customization.patch (text/x-diff) patch
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > I like your v2 even better. If it becomes possible to remove or soften > the "inter-row" horizontal line with CSS tricks afterwards, that would > be swell, but even without that, I cast my vote to using this table > format. I eventually figured out that the approved way to do per-table-entry customization is to attach "role" properties to the DocBook elements, and then key off the role names in applying formatting changes in the customization layer. So attached is a v3 that handles the desired formatting changes by applying a hanging indent to table <entry> contents if the entry is marked with role="functableentry". It may well be possible to do this in a cleaner fashion, but this seems good enough for discussion. I changed table 9.30 (Date/Time Operators) to this style, doing it exactly the same way as functions, just to see what it'd look like. I'm not sure if this is OK or if we want a separate column with just the operator name at the left --- it seems a little bit hard to spot the operator you want, but not impossible. Thoughts? Attached are screenshots of the same segment of table 9.10 as before and of the initial portion of 9.30, the patch against HEAD to produce these, and a hacky patch on the website's main.css to get it to go along. Without the last you just get all the subsidiary stuff left-justified if you build with STYLE=website, which isn't impossibly unreadable but it's not the desired presentation. I didn't include any screenshots of the PDF rendering, but it looks fine. regards, tom lane
Commits
-
Doc: re-re-revise markup for tables of functions.
- 4ad047a6eac3 13.0 landed
-
Doc: revise formatting of function/operator tables.
- 737d69ffc3cf 13.0 landed