Horton

Re: fairywren is generating bogus BASE_BACKUP commands

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-23T20:07:23Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> Maybe we need to have a README in the tree somewhere that tries to
> explain this. Or maybe we should make our build artifacts msys-aware,
> if that's possible, so that this just works. Or maybe supporting msys
> is not worth the trouble.

I've been wondering that last myself.  Supporting Windows-native is
already a huge amount of work, which we put up with because there
are a lot of users.  If msys is going to add another large chunk of
work, has it got enough users to justify that?

The recent argument that this behavior isn't user-visible doesn't do
anything to mollify me on that point; it appears to me to be tantamount
to a concession that no real users actually care about msys.

			regards, tom lane

Commits

  1. Remove PostgreSQL::Test::Utils::perl2host completely

  2. Unbreak pg_basebackup/t/010_pg_basebackup.pl on msys

  3. On Windows, also call shutdown() while closing the client socket.

  4. On Windows, close the client socket explicitly during backend shutdown.