Re: Foreign key isolation tests

Rustam ALLAKOV <rustamallakov@gmail.com>

From: Rustam ALLAKOV <rustamallakov@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Paul Jungwirth <pj@illuminatedcomputing.com>
Date: 2025-07-15T00:33:30Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi Paul,
Thank you for your prompt reply.

> I have the same --enable-* options.
> But does TESTNAME actually restrict your run to just those three?
> It doesn't for me.

It does not for us either. We somehow overlooked, sorry. It will run all the
118 tests specified at isolation_schedule file.

> As far as I know there is no way to run selected isolation tests,
> other than editing the isolation_schedule file

Thank you for explaining this, indeed modifying isolation_schedule file
does the trick on testing single spec only.

> Is there documentation saying that it should do something?
No there is none. TESTNAME variable was suggested by Claude 4.0 Sonnet.

We have rerun again 'make world' and 'make check-world' with your current
changes, all tests are passing. Thank you for all your clarifications!
We believe these are ready for committer.

Kindest regards.

The new status of this patch is: Ready for Committer

Commits

  1. Improve comment about snapshot macros

  2. Add test for temporal referential integrity

  3. Fill testing gap for possible referential integrity violation

  4. Simplify COALESCE() with one surviving argument.