Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Bryan Green <dbryan.green@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-12-21T22:48:54Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

ci: Test Windows + Mkvcbuild.pm in REL_16_STABLE.
- 4b9ce1ef609b 16.12 landed
Fix Mkvcbuild.pm builds of test_cloexec.c.
- 4da5c33a3a04 18.2 landed
- 45d92b76dc4a 19 (unreleased) landed
- 80e8ec772bff 16.12 landed
- b3c8119e28c0 17.8 landed
Clean up test_cloexec.c and Makefile.
- 0666ccc16cc2 16.12 landed
- 0451859131e5 17.8 landed
- a7d06e74d512 18.2 landed
- bec2a0aa3065 19 (unreleased) landed
Fix O_CLOEXEC flag handling in Windows port.
- d62a258cd45a 16.12 landed
- f24af0e04cef 17.8 landed
- bebb281b08b6 18.2 landed
- c507ba55f5bf 19 (unreleased) landed
Don't leak descriptors into subprograms.
- 1da569ca1f1f 16.0 cited

Thomas Munro <thomas.munro@gmail.com> writes:
> I pushed the cleanup patch.

fairywren's still not happy, though only in the v16 branch:

Could not determine contrib module type for test_cloexec
 at build.pl line 54.

This evidently is because the old MSVC build system doesn't
recognize

PROGRAM += test_cloexec
OBJS += $(WIN32RES) test_cloexec.o

Is there a reason for using += not just = here?  We could certainly
modify Mkvcbuild.pm to parse this if we need to, but it looks more
like a gratuitous difference from everyplace else than a useful
behavior.

			regards, tom lane