Horton

Re: [18] Unintentional behavior change in commit e9931bfb75

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@postgresql.org
Date: 2024-12-03T06:32:47Z
Lists: pgsql-hackers 
Jeff Davis <pgsql@j-davis.com> writes:
> On Mon, 2024-12-02 at 17:25 -0500, Tom Lane wrote:
>> Well, also for compatibility with our SQL parser's understanding
>> of identifier lowercasing.

> But why only for single-byte encodings? And why not for ICU?

I think the not-for-utf8 exclusion was mostly because that was
how it was before, which was probably mostly historical accident.
(I do vaguely recall that there was discussion on the point, but
I'm too tired to go look in the archives for it.)

As for ICU, that didn't exist back then, and I'm not going to
defend whether it was a good idea for that code path to fail
to reproduce this behavior.

			regards, tom lane

Commits

  1. Another unintentional behavior change in commit e9931bfb75.

  2. Improve comment in regc_pg_locale.c.

  3. Fix unintentional behavior change in commit e9931bfb75.

  4. Remove support for null pg_locale_t most places.

  5. Fix up handling of C/POSIX collations.