Re: additional contrib test suites
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
Thomas Munro <thomas.munro@enterprisedb.com>
Date: 2017-09-15T13:49:43Z
Lists: pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: > So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt() > doesn't support the traditional two-character salt format. > Option: > - Use the resultmap features to make this an expected failure on OpenBSD. > - Fix the module to work on OpenBSD. This would involve making a > platform-specific modification to use whatever advanced salt format they > want. > - Replace the entire module with something that does not depend on crypt(). Or (4) drop the module's regression test again. I'd go for (1) at least as a short-term answer. It's not clear to me that it's worth the effort to do (2) or (3). Also, (3) probably breaks backwards compatibility, if there is anyone out there actually using this datatype. regards, tom lane
Commits
-
Remove contrib/chkpass
- 5d3cad564729 11.0 landed
-
doc: Clarify pg_inherits description
- 0b554e4e63a4 11.0 cited