Horton
Menu

Re: Review: listagg aggregate

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, "David E. Wheeler" <david@kineticode.com>, "pgsql-hackers@postgresql.org Hackers" <pgsql-hackers@postgresql.org>
Date: 2010-01-28T17:24:33Z
Lists: pgsql-hackers 
Pavel Stehule <pavel.stehule@gmail.com> writes:
> with get_fn_expr_arg_stable() we are able to fix second parameter
> without some performance issues.

No, that will create its own performance issues ---
get_fn_expr_arg_stable isn't especially cheap.
If there were a really strong reason why we had to do it,
then I'd agree, but frankly the argument for disallowing
a variable delimiter is too thin.

			regards, tom lane