Horton
Menu

Re: gSoC - ADD MERGE COMMAND - code patch submission

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Fetter <david@fetter.org>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Boxuan Zhai <bxzhai2010@gmail.com>, pgsql-hackers@postgresql.org, heikki.linnakangas@enterprisedb.com
Date: 2010-07-10T16:45:58Z
Lists: pgsql-hackers 
David Fetter <david@fetter.org> writes:
> Please find enclosed a patch against git master as of
> 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75.  It works up to make, but
> fails on make check.

There seem to be about four different comment styles used in this patch,
none of which match the project standard:
http://developer.postgresql.org/pgdocs/postgres/source-format.html

BTW, I notice that that page fails to mention anything about preferred
window width.  I believe the project standard is to make things readable
in an 80-column window --- anyone have an objection to stating that
explicitly?

			regards, tom lane