Re: XversionUpgrade tests broken by postfix operator removal

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, pgbf@twiska.com
Date: 2020-09-19T11:46:49Z
Lists: pgsql-hackers
On 9/18/20 6:05 PM, Tom Lane wrote:
> I wrote:
>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>> Yeah, probably worth doing. It's a small enough change and it's only in
>>> the test suite.
>> OK, I'll go take care of that in a bit.
> Done, you should be able to remove @#@ (NONE, bigint) from the
> kill list.
>
> 			



Done.


crake tests pg_upgrade back to 9.2, so I had to mangle those static
repos for non-live branches like this:


    -- rel 9.2 on

    drop operator #%# (bigint, NONE);
    CREATE OPERATOR #%# (
        PROCEDURE = factorial,
        LEFTARG = bigint
    );


    drop operator #@# (bigint, NONE);
    CREATE OPERATOR #@# (
        PROCEDURE = factorial,
        LEFTARG = bigint
    );

    drop operator @#@ (NONE, bigint);
    CREATE OPERATOR @#@ (
        PROCEDURE = factorial,
        RIGHTARG = bigint
    );

    -- rel 9.4
    drop operator #@%# (bigint, NONE);
    CREATE OPERATOR public.#@%# (
        PROCEDURE = factorial,
        LEFTARG = bigint
    );


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




Commits

  1. In pg_upgrade cross-version test, handle postfix operators.

  2. Use factorial rather than numeric_fac in create_operator.sql.

  3. Remove support for postfix (right-unary) operators.