Horton

Re: Fix accidentally cast away qualifiers

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-20T08:16:26Z
Lists: pgsql-hackers 

> On Jan 20, 2026, at 15:54, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> This patch fixes cases where a qualifier (const, in all cases here) was dropped by a cast, but the cast was otherwise necessary or desirable, so the straightforward fix is to add the qualifier into the cast.
> 
> This was checked with gcc -Wcast-qual, but it doesn't fix all such warnings, only the trivially fixable ones.<0001-Fix-accidentally-cast-away-qualifiers.patch>

Looks good to me. All changes are const-correctness fixes without semantic changes.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Fix accidentally cast away qualifiers