Horton

Re: pg_basebackup's --gzip switch misbehaves

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-11-14T12:36:56Z
Lists: pgsql-hackers

Attachments

> On 3 Nov 2022, at 12:49, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Wed, Nov 02, 2022 at 09:42:12PM +0100, Daniel Gustafsson wrote:
>> I think that's a good idea, not everyone running tests will read the internals
>> documentation (or even know abou it even).  How about the attached?
> 
> Thanks for the patch.  Perhaps this should be mentioned additionally
> in install-windows.sgml?  I have not tested, but as long as these
> variables are configured with a "set" command in a command prompt,
> they would be passed down to the processes triggered by vcregress.pl
> (see for example TESTLOGDIR and TESTDATADIR).

That's probably a good idea, I've amended the patch with that and also made the
CPAN mention of IPC::Run into a ulink like how it is in the Windows section in
passing.  To avoid duplicating the info in the docs I made it into a sect2
which can be linked to.  How about this version?

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests

  2. doc: document the TAP test environment variables

  3. doc: update metacpan.org links to avoid redirects

  4. Use min/max bounds defined by Zstd for compression level

  5. Fix incorrect value for "strategy" with deflateParams() in walmethods.c

  6. Simplify handling of compression level with compression specifications