Horton

Thread

Commits

  1. Guard against reallocation failure in pg_regress

  1. reallocing without oom check in pg_regress

    Daniel Gustafsson <daniel@yesql.se> — 2022-02-23T21:32:30Z

    In pg_regress we realloc() with the destination and source pointer being equal,
without checking for OOM.  While a fairly unlikely source of errors, is there a
reason not to use pg_realloc() there for hygiene?

--
Daniel Gustafsson		https://vmware.com/

  2. Re: reallocing without oom check in pg_regress

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-02-23T22:05:15Z

    Daniel Gustafsson <daniel@yesql.se> writes:
> In pg_regress we realloc() with the destination and source pointer being equal,
> without checking for OOM.  While a fairly unlikely source of errors, is there a
> reason not to use pg_realloc() there for hygiene?

Yeah, looks like oversight to me.

			regards, tom lane

  3. Re: reallocing without oom check in pg_regress

    Daniel Gustafsson <daniel@yesql.se> — 2022-02-24T20:00:05Z

    > On 23 Feb 2022, at 23:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> In pg_regress we realloc() with the destination and source pointer being equal,
>> without checking for OOM.  While a fairly unlikely source of errors, is there a
>> reason not to use pg_realloc() there for hygiene?
> 
> Yeah, looks like oversight to me.

Thanks for confirming, I've pushed this now after taking it for a spin on the
CI just in case.

--
Daniel Gustafsson		https://vmware.com/