Horton

Thread

Commits

  1. Fix MSVC installations with multiple "configure" files detected

  1. BUG #16343: Build problem: Install.pm "Could not find debug or release binaries"

    The Post Office <noreply@postgresql.org> — 2020-04-04T15:08:31Z

    The following bug has been logged on the website:

Bug reference:      16343
Logged by:          Arnold Müller
Email address:      noeld.mueller@googlemail.com
PostgreSQL version: 12.0
Operating system:   Windows 10 Home
Description:        

During a build with vcpkg I got above error message during the install phase
after a successfull build phase.
(I tried to install
 ulibpq:x64-windows                                  12.0-1
)

It turned out that I got another, completely unrelated configure-file 7
folders up the hierarchy.
Inserting an elsif fixed it.

So, please consider merging this one into the Install.pm. It worked for me
on Windows 10 Home with vcpkg/MSVC, haven't tried it on other platforms,
though.

Thanks,
Arnold

diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index 1a92ed233a..9173d0ee53 100644
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -63,8 +63,14 @@ sub Install
 		do "./config.pl" if (-f "config.pl");
 	}
 
-	chdir("../../..")    if (-f "../../../configure");
-	chdir("../../../..") if (-f "../../../../configure");
+	if (-f "../../../configure")
+	{
+		chdir("../../..");
+	} 
+	elsif (-f "../../../../configure")
+	{
+		chdir("../../../..");
+	}
 	my $conf = "";
 	if (-d "debug")
 	{

  2. Re: BUG #16343: Build problem: Install.pm "Could not find debug or release binaries"

    Daniel Gustafsson <daniel@yesql.se> — 2020-04-06T06:36:29Z

    > On 4 Apr 2020, at 17:08, PG Bug reporting form <noreply@postgresql.org> wrote:

> It turned out that I got another, completely unrelated configure-file 7
> folders up the hierarchy.
> Inserting an elsif fixed it.
> 
> So, please consider merging this one into the Install.pm. It worked for me
> on Windows 10 Home with vcpkg/MSVC, haven't tried it on other platforms,
> though.

While I haven't tested it, the proposed change makes perfect sense, we need a
conditional between the two.  +1 on this.

cheers ./daniel

  3. Re: BUG #16343: Build problem: Install.pm "Could not find debug or release binaries"

    Daniel Gustafsson <daniel@yesql.se> — 2020-05-20T12:05:28Z

    > On 6 Apr 2020, at 08:36, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 4 Apr 2020, at 17:08, PG Bug reporting form <noreply@postgresql.org> wrote:
> 
>> It turned out that I got another, completely unrelated configure-file 7
>> folders up the hierarchy.
>> Inserting an elsif fixed it.
>> 
>> So, please consider merging this one into the Install.pm. It worked for me
>> on Windows 10 Home with vcpkg/MSVC, haven't tried it on other platforms,
>> though.
> 
> While I haven't tested it, the proposed change makes perfect sense, we need a
> conditional between the two.  +1 on this.

Can you please add this patch to the next commitfest to make it's not forgotten
about?

	https://commitfest.postgresql.org/28/

cheers ./daniel

  4. Re: BUG #16343: Build problem: Install.pm "Could not find debug or release binaries"

    Michael Paquier <michael@paquier.xyz> — 2020-05-21T05:47:03Z

    On Wed, May 20, 2020 at 02:05:28PM +0200, Daniel Gustafsson wrote:
> Can you please add this patch to the next commitfest to make it's not forgotten
> about?
> 
> 	https://commitfest.postgresql.org/28/

Applied and back-patched down to 9.5.  Sorry for the delay.
--
Michael