Horton

Re: Logical WAL sender unresponsive during decoding commit

x4mmm@yandex-team.ru

View thread View on postgr.es
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-08-16T09:06:01Z
Lists: pgsql-hackers 

> On 16 Aug 2022, at 10:25, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> 
> The same issue is recently reported[1] on -bugs
Oh, I missed that thread.

> and I proposed the
> patch that adds CHECK_FOR_INTERRUPTS() to the loop in
> ReorderBufferProcessTXN().
I agree that it's a good place for check.

> I think it should be backpatched.
Yes, I think so too.

> [1] https://www.postgresql.org/message-id/CAD21AoD%2BaNfLje%2B9JOqWbTiq1GL4BOp9_f7FxLADm8rS8cDhCQ%40mail.gmail.com

The patch in this thread looks good to me.


Thank you!

Best regards, Andrey Borodin.

Commits

  1. Add CHECK_FOR_INTERRUPTS while restoring changes during decoding.

  2. Add CHECK_FOR_INTERRUPTS while decoding changes.