Re: Review: listagg aggregate
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, "David E. Wheeler" <david@kineticode.com>, "pgsql-hackers@postgresql.org Hackers" <pgsql-hackers@postgresql.org>
Date: 2010-01-28T17:14:37Z
Lists: pgsql-hackers
2010/1/28 Robert Haas <robertmhaas@gmail.com>: > On Wed, Jan 27, 2010 at 9:47 PM, Takahiro Itagaki > <itagaki.takahiro@oss.ntt.co.jp> wrote: >> * Do we need better names for string_agg1_transfn and string_agg2_transfn? >> They are almost "internal names", but we could have more >> like string_agg_with_sep_transfn. > > Surely the names of the transition and final functions should match > the name of the aggregate. But if there's a proposal on the table to > call this string_app_with_sep() instead of just string_agg(), +1 from > me. no, >>>string_app_with_sep<<< is too long for common using. Pavel > > ...Robert >