Re: streaming replication breaks horribly if master crashes
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Josh Berkus <josh@agliodbs.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-17T16:43:13Z
Lists: pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes: > On Thu, Jun 17, 2010 at 5:26 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> The real problem here is that we're sending records to the slave which >> might cease to exist on the master if it unexpectedly reboots. I >> believe that what we need to do is make sure that the master only >> sends WAL it has already fsync'd (Tom suggested on another thread that >> this might be necessary, and I think it's now clear that it is 100% >> necessary). > The attached patch changes walsender so that it always sends WAL up to > LogwrtResult.Flush instead of LogwrtResult.Write. Applied, along with some minor comment improvements of my own. regards, tom lane