Horton

Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Jianghua Yang <yjhjstz@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-06-27T12:03:12Z
Lists: pgsql-hackers 
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Jun 26, 2025 at 01:46:10PM -0700, Jianghua Yang wrote:
>> These errors trace back to failures in `dsm_attach()`, where the
>> segment handle value was incorrectly interpreted due to sign extension
>> from `int32`.

> I think there might be something else going on.

I agree with Nathan: the patch you proposed is purely cosmetic.
I don't object to it, but you need to dig deeper because this
will not resolve any actual behavioral problem.

			regards, tom lane

Commits

  1. Use correct DatumGet*() function in test_shm_mq_main().