Re: match_clause_to_indexcol()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2010-11-20T18:51:37Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Nov 20, 2010 at 1:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think your revised patch is incorrect, or at least not terribly safe,
>> to just remove the last DoneMatchingIndexKeys test and not replace it
>> with anything else.

Oh, now that I look at it I notice the after-the-fact Assert claiming
that the clausegroup list isn't too long.  That can definitely be done
better.

>> Do you want to commit it yourself, or shall I incorporate it in a more
>> extensive cleanup?

> If it's all right with you, I'll go ahead and commit this and then you
> can break as much more stuff as you like.  :-)

Go for it.

			regards, tom lane