Re: pgsql: Remove unused wait events.
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
Amit Kapila <akapila@postgresql.org>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-25T17:34:37Z
Lists: pgsql-hackers
> On 25 Oct 2021, at 19:18, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Robert Haas <robertmhaas@gmail.com> writes: >> ... But while I agree it's good to remove unused stuff in the >> master, it doesn't seem like we really need to back-patch it. > > Yeah, exactly. I don't see any benefit that's commensurate with > even a small risk of breaking extensions --- and apparently, in > this case that's not a risk but a certainty. Since this will cause integer values to have different textual enum value representations in 14 and 15+, do we want to skip two numbers by assigning the next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three? Or enum integer reuse not something we guarantee against across major versions? -- Daniel Gustafsson https://vmware.com/
Commits
-
Revert "Remove unused wait events."
- a6a0ae127e76 14.1 landed
-
Remove unused wait events.
- 671eb8f34404 14.1 cited
-
Add support for streaming to built-in logical replication.
- 464824323e57 14.0 cited